Re: [HACKERS] log_destination=file - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] log_destination=file
Date
Msg-id 19639.1504284248@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] log_destination=file  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [HACKERS] log_destination=file  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Fri, Sep 1, 2017 at 6:00 PM, Greg Stark <stark@mit.edu> wrote:
>> So what happens now with these messages? My understanding is that
>> they're missing from the CSV logs and are simply inserted into the
>> text logs without any log_line_prefix? The logging collector doesn't
>> recognize these messages and reformat them for the CSV logs does it?

> Yeah, that's pretty much it.

> Fixing that is also on my plan, but for later :)

Keep in mind that you've got to be really, really conservative about
adding functionality in the logging collector process.  If it ever
crashes, we have problems.  If memory serves, the postmaster is able
to restart it, but we cannot restore the original stdout/stderr
destination, which is problematic if that's where its output had
been going.  So it's pretty close to being as mission-critical as
the postmaster itself.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] [bug fix] Savepoint-related statements terminates connection
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] Upcoming commit fest will begin soon