Re: [HACKERS] [bug fix] Savepoint-related statements terminates connection - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] [bug fix] Savepoint-related statements terminates connection
Date
Msg-id 19499.1504284042@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] [bug fix] Savepoint-related statements terminates connection  (Simon Riggs <simon@2ndquadrant.com>)
Responses Re: [HACKERS] [bug fix] Savepoint-related statements terminates connection
List pgsql-hackers
Simon Riggs <simon@2ndquadrant.com> writes:
> On 1 September 2017 at 15:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This patch makes me itch.  Why is it correct for these three checks,
>> and only these three checks out of the couple dozen uses of isTopLevel
>> in standard_ProcessUtility, to instead do something else?

> No problem, it was a quick fix, not a deep one.

My thought is that what we need to do is find a way for isTopLevel
to be false if we're processing a multi-command string.  It looks
like exec_simple_query is already doing the right thing in terms
of what it tells PortalRun; why is that not propagating down to
ProcessUtility?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Missing SIZE_MAX
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] log_destination=file