Re: [PATCH] Reserve protocol 3.1 explicitly in pqcomm.h - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Reserve protocol 3.1 explicitly in pqcomm.h
Date
Msg-id 1935052.1768950649@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Reserve protocol 3.1 explicitly in pqcomm.h  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: [PATCH] Reserve protocol 3.1 explicitly in pqcomm.h
List pgsql-hackers
Jacob Champion <jacob.champion@enterprisedb.com> writes:
> This is a tiny followup to https://postgr.es/c/0664aa4ff8 that
> enshrines the unused 3.1 protocol version as PG_PROTOCOL_RSRV31. The
> patch comes from [1]; I just wanted to give people the opportunity to
> bikeshed the name (or object to the move?) before it becomes part of a
> public header.

+1 for concept, but I agree the name needs bikeshedding.  "RSRV"
is unreadable, and people might well mentally expand it to
something involving "server", leading to confusion.

How about "PG_PROTOCOL_RESERVED_31" or
"PG_PROTOCOL_UNUSED_31"?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Mystery with REVOKE PRIVILEGE
Next
From: Jacob Champion
Date:
Subject: Re: [PATCH] Reserve protocol 3.1 explicitly in pqcomm.h