Request a Demo
Home   >   mailing lists

BUG #19066: postgresql-18.0/src/backend/optimizer/geqo/geqo_ox2.c:86: Array index check in wrong place ? - Mailing list pgsql-bugs

From PG Bug reporting form
Subject BUG #19066: postgresql-18.0/src/backend/optimizer/geqo/geqo_ox2.c:86: Array index check in wrong place ?
Date
Msg-id 19066-53bfa81d53f11b75@postgresql.org
Whole thread Raw
Responses Re: BUG #19066: postgresql-18.0/src/backend/optimizer/geqo/geqo_ox2.c:86: Array index check in wrong place ?
List pgsql-bugs
Tree view 
The following bug has been logged on the website:

Bug reference:      19066
Logged by:          David Binderman
Email address:      dcb314@hotmail.com
PostgreSQL version: 18.0
Operating system:   fedora 42
Description:

Static analyser cppcheck says:

postgresql-18.0/src/backend/optimizer/geqo/geqo_ox2.c:86:22: style: Array
index 'j' is used before limits check. [arrayIndexThenCheck]

Source code is

  while ((city_table[j].select_list == -1) && (j < num_gene))

Suggest new source code

  while ((j < num_gene) && (city_table[j].select_list == -1))

pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #19065: postgresql-18.0/src/bin/pg_combinebackup/reconstruct.c:230: Array sanity check in wrong place ?
Next
From: Todd Cook
Date:
Subject: Re: Postgres: Queries are too slow after upgrading to PG17 from PG15