Re: [PATCH] Fix select from wrong table array_op_test - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fix select from wrong table array_op_test
Date
Msg-id 1882787.1623425475@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Fix select from wrong table array_op_test  (Jason Kim <git@jasonk.me>)
Responses Re: [PATCH] Fix select from wrong table array_op_test
List pgsql-hackers
Jason Kim <git@jasonk.me> writes:
> In the middle of GIN index testing, there are some selects that are on
> a different table array_op_test that doesn't even have an index.  They
> probably were supposed to be selects to table array_index_op_test like
> the other ones around the area.

I think it's probably intentional, else why have two tables at all?
I suppose the point of these test cases is to confirm that you get the
same results with or without use of an index.

Certainly, there's more than one way to do that.  Perhaps we should
have only one table and perform the variant tests by manipulating
enable_indexscan et al.  But I think what you did here is defeating
the intent.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: logical replication of truncate command with trigger causes Assert
Next
From: Heikki Linnakangas
Date:
Subject: Re: [PATCH] Fix select from wrong table array_op_test