Re: PGXS: REGRESS_OPTS=--load-language=plpgsql - Mailing list pgsql-hackers

From David E. Wheeler
Subject Re: PGXS: REGRESS_OPTS=--load-language=plpgsql
Date
Msg-id 18602BCC-1854-4591-89A2-D9BC38F80887@kineticode.com
Whole thread Raw
In response to Re: PGXS: REGRESS_OPTS=--load-language=plpgsql  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: PGXS: REGRESS_OPTS=--load-language=plpgsql
List pgsql-hackers
On Feb 18, 2010, at 8:38 PM, Tom Lane wrote:

>> The regression test in the core is targeting only its version,
>> but some external projects have version-independent tests.
>
> I think it's more like "are under the fond illusion that their tests are
> version-independent".  Are we going to back out the next incompatible
> change we choose to make as soon as somebody notices that it breaks a
> third-party test case?  I don't think so.  Let me point out that
> choosing to install plpgsql by default has already broken "--single"
> restore of practically every pg_dump out there.  Nobody batted an eye
> about that.  Why are we suddenly so concerned about its effects on
> unnamed test suites?

Because it's a lot easier for `pg_regress --load-language=plpgsql` to mean "ensure the language is installed" than it
isfor 3rd-party test suites to detect what version they're being installed against. 

Really, all that has to happen is pg_regress in 8.5a4+ needs to just ignore `--load-language=plpgsql`. That's it.

Best,

David



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: testing cvs HEAD - HS/SR - PANIC: cannot make new WAL entries during recovery
Next
From: Magnus Hagander
Date:
Subject: Re: PGXS: REGRESS_OPTS=--load-language=plpgsql