Re: small explain patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: small explain patch
Date
Msg-id 18400.1020375733@sss.pgh.pa.us
Whole thread Raw
In response to small explain patch  (Liam Stewart <liams@redhat.com>)
Responses Re: small explain patch  (Liam Stewart <liams@redhat.com>)
List pgsql-patches
Liam Stewart <liams@redhat.com> writes:
> Attached is a small patch that clarifies EXPLAIN output a little bit.
> Output can be a bit confusing if there are spaces in table and index
> names and aliases so the names in question are surrounded by ' '.

If we do this, we should use double quotes "...".  A double-quoted
string is an identifier, a single-quoted string is a literal; and
it doesn't help anyone for the system's messages to get it backwards.
(I've been intending for awhile to fix all the elog messages that get
this wrong.)

How would you feel about quoting only if necessary
(cf. quote_identifier)?

> Aliases are explicitly labelled.

I think that's just noise.  The explain output is verbose enough without
adding noise words...

            regards, tom lane

pgsql-patches by date:

Previous
From: Liam Stewart
Date:
Subject: small explain patch
Next
From: Tom Lane
Date:
Subject: Re: small s_lock.c bug