Re: parallel restore fixes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: parallel restore fixes
Date
Msg-id 17972.1236642179@sss.pgh.pa.us
Whole thread Raw
In response to parallel restore fixes  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> + void
> + init_dump_utils()

This should be
> + void
> + init_dump_utils(void)

please.  We don't do K&R C around here.  I'd lose the added retval
variable too; that's not contributing anything.

> ! #endif;

Semicolon is bogus here.

Looks pretty sane otherwise.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: parallel restore fixes
Next
From: Tom Lane
Date:
Subject: Re: Updates of SE-PostgreSQL 8.4devel patches (r1704)