Re: Yet another (minor) fix in BRIN - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Yet another (minor) fix in BRIN
Date
Msg-id 1776964.1604807126@sss.pgh.pa.us
Whole thread Raw
In response to Re: Yet another (minor) fix in BRIN  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Yet another (minor) fix in BRIN  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2020-Nov-08, Tomas Vondra wrote:
>> While rebasing some of the BRIN patches, I noticed some of the code in
>> brin_memtuple_initialize is duplicated. This happened in 8bf74967dab
>> which moved some of the code from brin_new_memtuple, not removing the
>> shared pieces. In practice this is benign, of course.
>> 
>> Barring objections I'll get the attached fix committed and backpatched.

> LGTM, thanks for noticing.

The weekend before stable-branch releases is probably not the best
time to be pushing "minor" fixes into those branches.  I got my
fingers burned today, and so did Peter.  Don't follow our example ;-)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Yet another (minor) fix in BRIN
Next
From: Masahiko Sawada
Date:
Subject: Re: Transactions involving multiple postgres foreign servers, take 2