Re: C99 compliance for src/port/snprintf.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: C99 compliance for src/port/snprintf.c
Date
Msg-id 17667.1534356548@sss.pgh.pa.us
Whole thread Raw
In response to Re: C99 compliance for src/port/snprintf.c  (David Steele <david@pgmasters.net>)
List pgsql-hackers
David Steele <david@pgmasters.net> writes:
> On 8/15/18 12:17 PM, Tom Lane wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> Personally, I'd prefer to
>>> continue avoiding // comments and intermingled declarations of
>>> variables and code on grounds of style and readability.

>> ... which I agree with.

> We already have -Wdeclaration-after-statement to prevent mixed
> declarations.  Not sure what to do about comments except manual enforcement.

pgindent will change // comments to /* style, so at least on the timescale
of a release cycle, we have enforcement for that.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: C99 compliance for src/port/snprintf.c
Next
From: Andrew Dunstan
Date:
Subject: Re: C99 compliance for src/port/snprintf.c