Re: Darwin compile fixes - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Darwin compile fixes
Date
Msg-id 17543.1129177736@sss.pgh.pa.us
Whole thread Raw
In response to Darwin compile fixes  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Darwin compile fixes  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Attached is a cleaned up version of the patch (without wrapping).  The
> change is to use "$(CXX) $(CFLAGS)" instead of $(COMPILER).  Does this
> change break OS/X?

Since our configure doesn't define CXX, I'm having a hard time imagining
how it could fail to break it.

If we *did* define CXX, it would presumably point to g++, which would
also break things since our source code is not C++ clean.

Even more to the point, Darwin isn't broken now --- at least it works
fine on the powerbook I'm typing this on, and on the several OSX
machines in the buildfarm.

I would like to know what this patch is alleged to fix before even
considering applying it.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Neil Conway
Date:
Subject: Re: Minor point about contrib/xml2 functions "IMMUTABLE"
Next
From: Tom Lane
Date:
Subject: Re: A costing analysis tool