Re: [HACKERS] GnuTLS support - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [HACKERS] GnuTLS support
Date
Msg-id 1719CF5C-6350-41C6-84E7-83403AE8BECA@yesql.se
Whole thread Raw
In response to Re: [HACKERS] GnuTLS support  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
> On 19 Jan 2018, at 19:43, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:

> 0003-Move-EDH-support-to-common-files.patch
>
> To avoid copy-and-paste, and also because the EDH explanation doesn't
> really belong in a file header comment.  Maybe the whole thing is known
> well enough nowadays that we can just remove the explanation.

Perhaps, I still think it’s a good idea to keep it in README.SSL

> 0004-Move-SSL-API-comments-to-header-files.patch
> 0005-Extract-common-bits-from-OpenSSL-implementation.patch
>
> Move copy-and-paste avoidance.

+1 on doing this type of refactoring before anything else lands, when
implementing ST the excessive copy-paste was annoying (but avoided for
scope-creep).

cheers ./daniel

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions
Next
From: Tomas Vondra
Date:
Subject: Re: Logical Decoding and HeapTupleSatisfiesVacuum assumptions