Re: Remove fls(), use pg_bitutils.h facilities instead? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove fls(), use pg_bitutils.h facilities instead?
Date
Msg-id 1692961.1658324916@sss.pgh.pa.us
Whole thread Raw
In response to Re: Remove fls(), use pg_bitutils.h facilities instead?  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Remove fls(), use pg_bitutils.h facilities instead?
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> That double eval macro wasn't nice.  This time with a static inline function.

Seems like passing a size_t to pg_leftmost_one_pos32 isn't great.
It was just as wrong before (if the caller-supplied argument is
indeed a size_t), but no time like the present to fix it.

We could have pg_bitutils.h #define pg_leftmost_one_pos_size_t
as the appropriate one of pg_leftmost_one_pos32/64, perhaps.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi