Re: add checkpoint stats of snapshot and mapping files of pg_logical dir - Mailing list pgsql-hackers

From Cary Huang
Subject Re: add checkpoint stats of snapshot and mapping files of pg_logical dir
Date
Msg-id 163823361875.8893.16011115215407536326.pgcf@coridan.postgresql.org
Whole thread Raw
In response to add checkpoint stats of snapshot and mapping files of pg_logical dir  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: add checkpoint stats of snapshot and mapping files of pg_logical dir
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            not tested

Hi

The patch applies and tests fine. I don't think there is any harm having little extra statistical information about the
checkpointprocess. In fact, it could be useful in identifying a bottleneck during the checkpoint process as the stats
exactlythe time taken to do the file IO in pg_logical dir. 
 

best

Cary Huang

pgsql-hackers by date:

Previous
From: Andy Fan
Date:
Subject: Re: Can I assume relation would not be invalid during from ExecutorRun to ExecutorEnd
Next
From: Andy Fan
Date:
Subject: Re: Can I assume relation would not be invalid during from ExecutorRun to ExecutorEnd