Re: variadic function support - Mailing list pgsql-patches

From Pavel Stehule
Subject Re: variadic function support
Date
Msg-id 162867790807122252ta082f21t3b9af19aebc34cc6@mail.gmail.com
Whole thread Raw
In response to Re: variadic function support  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: variadic function support
List pgsql-patches
Hello

2008/7/13 Jeff Davis <pgsql@j-davis.com>:
> On Thu, 2008-06-26 at 17:03 +0200, Pavel Stehule wrote:
>> this is third variant with variadic argumen as scalar. But I still
>> strongly prefer second variant with conformance declared variadic
>> array with used array variable.
>

you checked second or third variant? There are two variants still.
Regards
Pavel Stehule

Please, Tom, can you choose one?

> This version allows you to declare two functions "foo(variadic numeric)"
> and "foo(numeric)", and then if you do a "\df foo" the backend crashes.
>
> Also, you didn't update an error string:
>
> "variadic argument isn't an array" should (in this version) be something
> like: "can't find array type for variadic parameter type %s"
>
> I suggest a slightly different wording for the following error messages:
>
> "aggregate function has variadic argument" -> "variadic parameters not
> supported for aggregate functions"
>
> and
>
> "variadic argument isn't last function's argument" -> "variadic
> parameter must be the last parameter to the function"
>
> Those are just suggested wordings.
>
> Regards,
>        Jeff Davis
>
>

pgsql-patches by date:

Previous
From: Jeff Davis
Date:
Subject: Re: variadic function support
Next
From: Jeff Davis
Date:
Subject: Re: variadic function support