Re: match_clause_to_indexcol() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: match_clause_to_indexcol()
Date
Msg-id 16178.1290279097@sss.pgh.pa.us
Whole thread Raw
In response to Re: match_clause_to_indexcol()  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: match_clause_to_indexcol()
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Sat, Nov 20, 2010 at 1:37 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think your revised patch is incorrect, or at least not terribly safe,
>> to just remove the last DoneMatchingIndexKeys test and not replace it
>> with anything else.

Oh, now that I look at it I notice the after-the-fact Assert claiming
that the clausegroup list isn't too long.  That can definitely be done
better.

>> Do you want to commit it yourself, or shall I incorporate it in a more
>> extensive cleanup?

> If it's all right with you, I'll go ahead and commit this and then you
> can break as much more stuff as you like.  :-)

Go for it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: match_clause_to_indexcol()
Next
From: Robert Haas
Date:
Subject: Re: Fwd: What do these terms mean in the SOURCE CODE?