Re: pg_hba.conf - patch to report all parsing errors, and then bail - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_hba.conf - patch to report all parsing errors, and then bail
Date
Msg-id 15918.1236451909@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_hba.conf - patch to report all parsing errors, and then bail  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pg_hba.conf - patch to report all parsing errors, and then bail  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Tom Lane wrote:
>> It sure looks like that's going to try to free new_parsed_lines more
>> than once.  Shouldn't clean_hba_list be done just once?

> Yeah, it should be done in the if branch down below. And I think by our
> coding standards (or at least by our conventions), the variable should
> be "ok" and not "OK".

> Unless there are any objections, I can do those cleanups and apply it.

I thought the adjacent comments could do with a bit more wordsmithing,
also, but otherwise that about covers it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pg_hba.conf - patch to report all parsing errors, and then bail
Next
From: Dimitri Fontaine
Date:
Subject: Re: Out parameters handling