Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> You seem to have entirely missed the point of Alvaro's remark, which is
>> that you've got xlog.h including walsender.h (still) as well as
>> walsender.h including xlog.h. That's broken.
> Oh, OK, done. xlog.h removed from walsender.h and tested.
I would have gone the other way on that one, if possible. Seems like
xlog.h ought to be the lower-level file.
Some quick mechanical analysis shows that's not the only circular
inclusion path in our headers, either: we have storage/proc.h including
replication/syncrep.h which includes storage/proc.h. That one appears
to be Simon's fault not yours though.
regards, tom lane
