Re: pgbench - add option to show actual builtin script code - Mailing list pgsql-hackers

From Ibrar Ahmed
Subject Re: pgbench - add option to show actual builtin script code
Date
Msg-id 155680531862.1409.1208274148953704839.pgcf@coridan.postgresql.org
Whole thread Raw
In response to pgbench - add option to show actual builtin script code  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: pgbench - add option to show actual builtin script code  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Patch looks good to me, and work fine on my machine. One minor observation is option 'list' mostly used to list the
elementslike "pgbench -b list" shows the available builtin scripts. Therefore we should use a word which seems to be
morerelevant like --show-script. 

The new status of this patch is: Waiting on Author

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs
Next
From: Simon Riggs
Date:
Subject: Re: walsender vs. XLogBackgroundFlush during shutdown