Re: pgsql: Add missing "static" qualifier. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Add missing "static" qualifier.
Date
Msg-id 1538.1455301192@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add missing "static" qualifier.  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pgsql: Add missing "static" qualifier.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Feb 12, 2016 at 11:20 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Add missing "static" qualifier.
>>
>> Per buildfarm member pademelon.

> Gah.  Sorry I keep missing these.

It's a pain that gcc won't warn about it.  On the other hand, it's
probably only neatnik-ism on my part to care; I do not know of any
compilers that would actually give an error.  It only seems worth
fixing to me because whether a function is static or not is important
information, so I like functions to be accurately labeled.

            regards, tom lane


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Add missing "static" qualifier.
Next
From: Tom Lane
Date:
Subject: pgsql: Re-pgindent isolationtester.c.