Re: Rethinking representation of partial-aggregate steps - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Rethinking representation of partial-aggregate steps
Date
Msg-id 1473.1466870870@sss.pgh.pa.us
Whole thread Raw
In response to Re: Rethinking representation of partial-aggregate steps  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Rethinking representation of partial-aggregate steps  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
I wrote:
> David Rowley <david.rowley@2ndquadrant.com> writes:
>> The attached implements this, with the exception that I didn't really
>> think AggPartialMode was the best name for the enum. I've named this
>> AggregateMode instead, as the aggregate is only partial in some cases.

> Hm.  We already have an AggStrategy (for hashed vs. grouped aggregation)
> so adding AggregateMode beside it seems somewhere between confusing and
> content-free.  And it's needlessly inconsistent with the spelling of the
> existing enum name.  I'm not wedded to "AggPartialMode" but I think
> we need some name that's a bit more specific than "AggregateMode".
> Suggestions anyone?

After a bit of thought, maybe AggDivision or AggSplit or something
along those lines?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Rethinking representation of partial-aggregate steps
Next
From: Tom Lane
Date:
Subject: Better solution to final adjustment of combining Aggrefs