Re: An example of bugs for Hot Standby - Mailing list pgsql-hackers

From Tom Lane
Subject Re: An example of bugs for Hot Standby
Date
Msg-id 14578.1264006776@sss.pgh.pa.us
Whole thread Raw
In response to Re: An example of bugs for Hot Standby  (Andres Freund <andres@anarazel.de>)
Responses Re: An example of bugs for Hot Standby  (Andres Freund <andres@anarazel.de>)
Re: An example of bugs for Hot Standby  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> I realize its way too late in the cycle for that, but why dont we start using
> some library for easy cross platform atomic ops?

(1) there probably isn't one that does exactly what we want, works
everywhere, and has the right license;
(2) what actual gain would we get?  We've already done the work.

>> [ grows visibly pale ]  *Please* tell me we are not trying to take
>> locks in a signal handler.  What happens if it interrupts code that
>> is already holding that lock?

> Yes the patch does that at two places.

That's a must-fix.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: MySQL-ism help patch for psql
Next
From: Dimitri Fontaine
Date:
Subject: Re: MySQL-ism help patch for psql