Re: don't allocate HashAgg hash tables when running explain only - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: don't allocate HashAgg hash tables when running explain only
Date
Msg-id 13c493f8-f459-1798-0944-fb6dda92cb37@iki.fi
Whole thread Raw
In response to Re: don't allocate HashAgg hash tables when running explain only  (Greg Stark <stark@mit.edu>)
Responses Re: don't allocate HashAgg hash tables when running explain only  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 19/11/2020 07:20, Greg Stark wrote:
> On Wed, 18 Nov 2020 at 05:40, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>>
>> On 13/11/2020 18:10, Alexey Bashtanov wrote:
>>>> I would appreciate if someone could have a look at the patch attached,
>>> which makes executor skip initializing hash tables when doing explain only.
>>
>> Makes sense. Committed, thanks for the patch!
> 
> Egads. That seems like a backpatchable bug fix to me. Have we been
> doing this all along?!

Yeah, I believe it's always been like that. Yeah, arguably it should be 
backpatched. I felt conservative and didn't backpatch, but feel free to 
do it if you think it should be.

- Heikki



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Should we document IS [NOT] OF?
Next
From: "David G. Johnston"
Date:
Subject: Re: Should we document IS [NOT] OF?