Re: Speaking of breaking compatibility...standard_conforming_strings - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Speaking of breaking compatibility...standard_conforming_strings
Date
Msg-id 13982.1464119825@sss.pgh.pa.us
Whole thread Raw
In response to Speaking of breaking compatibility...standard_conforming_strings  ("David G. Johnston" <david.g.johnston@gmail.com>)
Responses Re: Speaking of breaking compatibility...standard_conforming_strings  ("David G. Johnston" <david.g.johnston@gmail.com>)
List pgsql-hackers
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> I just noticed this comment in scan.l:
> /*
>  * GUC variables.  This is a DIRECT violation of the warning given at the
>  * head of gram.y, ie flex/bison code must not depend on any GUC variables;
>  * as such, changing their values can induce very unintuitive behavior.
>  * But we shall have to live with it as a short-term thing until the switch
>  * to SQL-standard string syntax is complete.
>  */
> int backslash_quote = BACKSLASH_QUOTE_SAFE_ENCODING;
> bool escape_string_warning = true;
> bool standard_conforming_strings = true;

> I'm not exactly sure what else needs to happen to remove these forbidden
> GUCs and if we are not prepared to do this now when will we ever be...

Dunno, are you prepared to bet that nobody is turning off
standard_conforming_strings anymore?

In any case, we keep adding new violations of this rule (cf
operator_precedence_warning) so I have little hope that it will ever be
completely clean.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Next
From: Alvaro Herrera
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <