Re: psql should show disabled internal triggers - Mailing list pgsql-hackers

From fabriziomello
Subject Re: psql should show disabled internal triggers
Date
Msg-id 1382722644772-5775954.post@n5.nabble.com
Whole thread Raw
In response to Re: psql should show disabled internal triggers  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: psql should show disabled internal triggers  (Fabrízio de Royes Mello <fabriziomello@gmail.com>)
List pgsql-hackers
On 2013-09-18 15:15:55 +0200, Bernd Helmle wrote:
> On 2013-09-18 15:15:55 +0200, Bernd Helmle wrote:
> > --On 18. September 2013 13:52:29 +0200 Andres Freund
> > <andres@> wrote:
> >
> > >If you do ALTER TABLE ... DISABLE TRIGGER ALL; and then individually
> > >re-enable the disabled triggers it's easy to miss internal triggers.
> > >A \d+ tablename will not show anything out of the ordinary for that
> > >situation since we don't show internal triggers. But foreign key checks
> > >won't work.
> > >So, how about displaying disabled internal triggers in psql?
> >
> > Hi had exactly the same concerns this morning while starting to look at
> the
> > ENABLE/DISABLE constraint patch. However, i wouldn't display them as
> > triggers, but maybe more generally as "disabled constraints" or such.
>
> Well, that will lead the user in the wrong direction, won't it? They
> haven't disabled the constraint but the trigger. Especially as we
> already have NOT VALID and might grow DISABLED for constraint
> themselves...
>

Hi,

The attached patch [1] enable PSQL to list internal disabled triggers in \d
only in
versions >= 9.0.

[1]  psql-display-all-triggers-v1.patch
<http://postgresql.1045698.n5.nabble.com/file/n5775954/psql-display-all-triggers-v1.patch>

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello



-----
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
--
View this message in context:
http://postgresql.1045698.n5.nabble.com/psql-should-show-disabled-internal-triggers-tp5771406p5775954.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.



pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: CLUSTER FREEZE
Next
From: Robert Haas
Date:
Subject: Re: Detection of nested function calls