Re: a modest improvement to get_object_address() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: a modest improvement to get_object_address()
Date
Msg-id 13761.1320852790@sss.pgh.pa.us
Whole thread Raw
In response to Re: a modest improvement to get_object_address()  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: a modest improvement to get_object_address()
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Nov 9, 2011 at 9:54 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I would think you need to drop the now-useless lock, and I sure hope
>> that RangeVarGetRelid does likewise.

> It doesn't currently.  The now-useless lock doesn't really hurt
> anything, aside from taking up space in the lock table.

Well, there are corner cases where the object OID gets reused during
the lifetime of the transaction, and then the lock *does* do something
(and what it does would be bad).  But taking up extra space in the
finite-size lock table is sufficient reason IMO to drop the lock.
It's not like these are performance-critical code paths.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Emanuel Calvo
Date:
Subject: Re: [Feature Request] \dx show "options"
Next
From: "Kevin Grittner"
Date:
Subject: Re: const correctness