Re: PRI?64 vs Visual Studio (2022) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: PRI?64 vs Visual Studio (2022)
Date
Msg-id 1372793.1763519315@sss.pgh.pa.us
Whole thread Raw
In response to Re: PRI?64 vs Visual Studio (2022)  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: PRI?64 vs Visual Studio (2022)
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> We don't even test -Dnls on the Windows CI task, so the fact that it
> passes there doesn't mean much (if our tests would even pick up
> <PRI*64> expansion failure, not sure).  We should probably do
> something about that and/or its absence from the build farm.  We're
> effectively counting on the EDB packaging team or end users to tell us
> if we break localisation on this platform.

I'm pretty certain that we do not test NLS localization at all,
anywhere :-(.  (There are no test cases checking enable_nls,
which would be a necessary thing to not fail on buildfarm critters
not using NLS.)

I agree that starting to rely on PRI?64 in translatable strings
is raising the bar a good deal, so maybe it's time to do something
about that.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Use merge-based matching for MCVs in eqjoinsel
Next
From: Michael Paquier
Date:
Subject: Re: make -C src/test/isolation failure in index-killtuples due to btree_gist