[PATCH] Fix off-by-one in PQprintTuples() - Mailing list pgsql-hackers

From Xi Wang
Subject [PATCH] Fix off-by-one in PQprintTuples()
Date
Msg-id 1358657511-32752-1-git-send-email-xi.wang@gmail.com
Whole thread Raw
Responses Re: [PATCH] Fix off-by-one in PQprintTuples()
List pgsql-hackers
Don't write past the end of tborder; the size is width + 1.
---src/interfaces/libpq/fe-print.c |    2 +-1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/interfaces/libpq/fe-print.c b/src/interfaces/libpq/fe-print.c
index 076e1cc..7ed489a 100644
--- a/src/interfaces/libpq/fe-print.c
+++ b/src/interfaces/libpq/fe-print.c
@@ -706,7 +706,7 @@ PQprintTuples(const PGresult *res,                fprintf(stderr, libpq_gettext("out of
memory\n"));               abort();            }
 
-            for (i = 0; i <= width; i++)
+            for (i = 0; i < width; i++)                tborder[i] = '-';            tborder[i] = '\0';
fprintf(fout,"%s\n", tborder);
 
-- 
1.7.10.4




pgsql-hackers by date:

Previous
From: Xi Wang
Date:
Subject: [PATCH] Fix NULL checking in check_TSCurrentConfig()
Next
From: Amit kapila
Date:
Subject: Re: Review: Patch to compute Max LSN of Data Pages