[PATCH] Fix NULL checking in check_TSCurrentConfig() - Mailing list pgsql-hackers

From Xi Wang
Subject [PATCH] Fix NULL checking in check_TSCurrentConfig()
Date
Msg-id 1358657486-32676-1-git-send-email-xi.wang@gmail.com
Whole thread Raw
Responses Re: [PATCH] Fix NULL checking in check_TSCurrentConfig()
Re: [PATCH] Fix NULL checking in check_TSCurrentConfig()
Re: [PATCH] Fix NULL checking in check_TSCurrentConfig()
List pgsql-hackers
The correct NULL check should use `*newval'; `newval' must be non-null.
---src/backend/utils/cache/ts_cache.c |    2 +-1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/cache/ts_cache.c b/src/backend/utils/cache/ts_cache.c
index e688b1a..65a8ad7 100644
--- a/src/backend/utils/cache/ts_cache.c
+++ b/src/backend/utils/cache/ts_cache.c
@@ -642,7 +642,7 @@ check_TSCurrentConfig(char **newval, void **extra, GucSource source)        free(*newval);
*newval= strdup(buf);        pfree(buf);
 
-        if (!newval)
+        if (!*newval)            return false;    }
-- 
1.7.10.4




pgsql-hackers by date:

Previous
From: Steve Singer
Date:
Subject: Re: logical changeset generation v4
Next
From: Xi Wang
Date:
Subject: [PATCH] Fix off-by-one in PQprintTuples()