Re: external_pid_file not removed on postmaster exit - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: external_pid_file not removed on postmaster exit
Date
Msg-id 1345182201.19882.1.camel@vanquo.pezone.net
Whole thread Raw
In response to external_pid_file not removed on postmaster exit  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Fri, 2012-07-27 at 08:09 +0300, Peter Eisentraut wrote:
> It seems strange that the external_pid_file is never removed.  There is
> even a C comment about it:
>
> /* Should we remove the pid file on postmaster exit? */
>
> I think it should be removed with proc_exit hook just like the main
> postmaster.pid file.
>
> Does anyone remember why this was not done originally or have any
> concerns?

Since that was not the case, I propose the attached patch to unlink the
external pid file.

Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: review: CHECK FUNCTION statement
Next
From: Fabrízio de Royes Mello
Date:
Subject: Re: CREATE SCHEMA IF NOT EXISTS