Re: patch for parallel pg_dump - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: patch for parallel pg_dump
Date
Msg-id 1333468540-sup-7880@alvh.no-ip.org
Whole thread Raw
In response to Re: patch for parallel pg_dump  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: patch for parallel pg_dump
List pgsql-hackers
Excerpts from Tom Lane's message of mar abr 03 12:38:20 -0300 2012:
>
> Robert Haas <robertmhaas@gmail.com> writes:
> > On Tue, Apr 3, 2012 at 10:40 AM, Joachim Wieland <joe@mcknight.de> wrote:
> >> I completely agree. Assertions helped a lot dealing with concurrent
> >> code. How do you want to tackle this for now? Want me to create a
> >> separate header pg_assert.h as part of my patch? Or is it okay to
> >> factor it out later and include it from the general header then?
>
> > I'll just go do it, barring objections.
>
> If the necessary support code isn't going to be available *everywhere*,
> it should not be in postgres.h.  So I did not care for your proposal to
> put it in dumputils.
>
> Possibly we could move assert.c into src/port/ and make it part of
> libpgport?

That only leaves assert_enabled to be handled.  In the backend it lives
in guc.c; what to do about frontend code?

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Christopher Browne
Date:
Subject: Re: Switching to Homebrew as recommended Mac install?
Next
From: Tom Lane
Date:
Subject: Re: patch for parallel pg_dump