Re: Group commit, revised - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Group commit, revised
Date
Msg-id 1326846575-sup-4645@alvh.no-ip.org
Whole thread Raw
In response to Re: Group commit, revised  (Jim Nasby <jim@nasby.net>)
List pgsql-hackers
Excerpts from Jim Nasby's message of mar ene 17 21:21:57 -0300 2012:
> On Jan 15, 2012, at 4:42 PM, Peter Geoghegan wrote:
> > Attached is a patch that myself and Simon Riggs collaborated on. I
> > took the group commit patch that Simon posted to the list back in
> > November, and partially rewrote it.
>
> Forgive me if this is a dumb question, but I noticed a few places doing things like:
>
> if (...)
>   Blah();
> else
> {
>   ...
> }
>
> Is that allowed PG formatting? I thought that if braces were required on one branch of an if they were supposed to go
onboth sides. 

Yeah, we even used to have pg_indent remove braces around single
statements, so if you had one statement in the "if" branch and more
around the other one, pg_indent would have left things like that anyway.

(This particular pg_indent behavior got removed because it messed up
PG_TRY blocks.)

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: Group commit, revised
Next
From: Greg Smith
Date:
Subject: Re: [WIP] Double-write with Fast Checksums