Re: tablesample test failure with small TOAST_TUPLE_THRESHOLD - Mailing list pgsql-hackers

From Tom Lane
Subject Re: tablesample test failure with small TOAST_TUPLE_THRESHOLD
Date
Msg-id 13200.1476468141@sss.pgh.pa.us
Whole thread Raw
In response to Re: tablesample test failure with small TOAST_TUPLE_THRESHOLD  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Oct 14, 2016 at 9:51 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Possibly we should be using a less chintzy (ie slower) test there,
>> but a change like this would inevitably change the outputs anyway.

> OK.  So passing the regression tests with different values of
> TOAST_TUPLE_THRESHOLD is not a goal?  I wasn't sure about that, but if
> the answer is "no, that's not a goal", that's fine.

For that particular test, I really fail to see how we could make the
output entirely independent of the number of tuples stored per page.
By design, that tablesample method is sensitive to where the page
boundaries are.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.
Next
From: Robert Haas
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.