strange code in array_in - Mailing list pgsql-hackers

From Jeff Davis
Subject strange code in array_in
Date
Msg-id 1319905890.21603.10.camel@jdavis
Whole thread Raw
Responses Re: strange code in array_in  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
In array_in(), I see the following code:
 my_extra->element_type = ~element_type;

It seems like it was explicitly changed from InvalidOid to
~element_type. At first I thought it was a mistake, but then I thought
maybe it was to ensure that the next branch was taken even if
element_type == InvalidOid. But the rest of the lookups will surely fail
on InvalidOid, and it seems like it would be easy to test for InvalidOid
at the beginning if we wanted to fail.

Can someone please explain, and perhaps include a comment indicating
what's going on? Or is it just too early and I missed something simple?

Regards,Jeff Davis





pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql_fdw, FDW for PostgreSQL server
Next
From: horiguchi.kyotaro@oss.ntt.co.jp
Date:
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases