Andrew Dunstan <andrew@dunslane.net> writes:
> I will apply the attached patch tomorrow, barring objection. This covers
> drop if exists for the following objects:
> table view index sequence schema type domain conversion
> I have a simple test script as show below, but I am not sure where to
> put it in the regression tests - add a new one maybe?
New test seems reasonable.
A few other minor comments:
* The NOTICEs should probably not carry an ERRCODE; usually you just
want a notice to go out with the default "not an error" SQLSTATE.
* The "Assert(missing_ok)"s are a waste of code space --- if
ereport(ERROR) ever returned, there would be vast swaths of the backend
that fail, so there's no point in asserting it only here. They also
make the reader stop to wonder why they are there, which is probably a
bigger objection.
* It's probably not a good idea to assume that "IF" is a safe name for
a parser symbol --- too much risk of collision with other macros.
I'd suggest "IF_P".
regards, tom lane
