Re: possible connection leak in dblink? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: possible connection leak in dblink?
Date
Msg-id 1308338461.16852.0.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: possible connection leak in dblink?  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: possible connection leak in dblink?
List pgsql-hackers
On ons, 2011-06-15 at 11:41 +0900, Fujii Masao wrote:
> ISTM that the root problem is that dblink_send_query calls DBLINK_GET_CONN
> though it doesn't accept the connection string as an argument. Since the first
> argument in dblink_send_query must be the connection name, dblink_send_query
> should call DBLINK_GET_NAMED_CONN instead. The variable 'freeconn' is used
> only when DBLINK_GET_CONN is called. So, if dblink_send_query uses
> DBLINK_GET_NAMED_CONN instead, the variable 'freeconn' is no longer necessary.
> 
> The similar problem exists in dblink_get_result and dblink_record_internal.
> Attached patch fixes those problems.

Is this a bug fix that should be backpatched?



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe
Next
From: Simon Riggs
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe