Re: [BUGS] BUG #6034: pg_upgrade fails when it should not. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.
Date
Msg-id 1306341572-sup-4765@alvh.no-ip.org
Whole thread Raw
In response to Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Excerpts from Bruce Momjian's message of mar may 24 15:59:59 -0400 2011:

> > I think you misread what I wrote, or I misexplained it, but never
> > mind.  Matching locale names case-insensitively sounds reasonable to
> > me, unless someone has reason to believe it will blow up.
> 
> OK, that's what I needed to hear.  I have applied the attached patch,
> but only to 9.1 because  of the risk of breakage. (This was only the
> first bug report of this, and we aren't 100% certain about the case
> issue.)

Hmm, I know the locale can be spelled "en_US.UTF-8" (note dash) in some
systems.  So if you have a locale alias that makes en_US.utf8 the same
as en_US.UTF-8, the patched code would still not work.  I wonder if
there's a need for canonicalization somewhere.  Or maybe this is just
not worth the trouble.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: [ADMIN] pg_class reltuples/relpages not updated by autovacuum/vacuum
Next
From: Tom Lane
Date:
Subject: Re: [ADMIN] pg_class reltuples/relpages not updated by autovacuum/vacuum