Re: Cleanup of /contrib - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Cleanup of /contrib
Date
Msg-id 13044.1034903195@sss.pgh.pa.us
Whole thread Raw
In response to Cleanup of /contrib  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Cleanup of /contrib  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I am cleaning up /contrib by adding "autocommit = 'on'" and making it
> more consistent.  Should I be adding this too:

>     -- Adjust this setting to control where the objects get created.
>     SET search_path = public;

Yes, that would be a good idea.  Without that, the objects might well
get created in the owning user's private schema; which most of the time
would be unhelpful.  I'm not thrilled with having to edit the script
if you do happen to want them in a non-public schema, but I have not
thought of a better approach yet.  (Anyone?)

> and doing all object creation in one transaction, like /contrib/cube
> does?

The one-transaction thing seems unnecessary to me, but if you like it...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Current CVS has strange parser for float type
Next
From: Bruce Momjian
Date:
Subject: Re: Cleanup of /contrib