Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v
Date
Msg-id 1298673635-sup-7604@alvh.no-ip.org
Whole thread Raw
In response to Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Excerpts from Tom Lane's message of vie feb 25 19:31:13 -0300 2011:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Fix pageinspect's heap_page_item to return infomasks as 32 bit values
> > HeapTupleHeader's t_infomask and t_infomask2 are defined as 16-bit
> > unsigned integers, so when the 16th bit was set, heap_page_item was
> > returning them as negative values, which was ugly.
>
> > The change to pageinspect--unpackaged--1.0.sql allows a module upgraded
> > from 9.0 to be cleanly updated from the previous definition.
>
> I think you forgot to commit the matching change in pageinspect--1.0.sql ?

Oops, yeah, thanks.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Update pageinspect--1.0.sql to match the upgrade script
Next
From: Tom Lane
Date:
Subject: pgsql: Support data-modifying commands (INSERT/UPDATE/DELETE) in WITH.