Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v
Date
Msg-id 1137.1298673073@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-committers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Fix pageinspect's heap_page_item to return infomasks as 32 bit values
> HeapTupleHeader's t_infomask and t_infomask2 are defined as 16-bit
> unsigned integers, so when the 16th bit was set, heap_page_item was
> returning them as negative values, which was ugly.

> The change to pageinspect--unpackaged--1.0.sql allows a module upgraded
> from 9.0 to be cleanly updated from the previous definition.

I think you forgot to commit the matching change in pageinspect--1.0.sql ?

            regards, tom lane

pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Update pageinspect--1.0.sql to match the upgrade script