Re: pl/python refactoring - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pl/python refactoring
Date
Msg-id 1295729621.1770.3.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: pl/python refactoring  (Jan Urbański <wulczer@wulczer.org>)
Responses Re: pl/python refactoring
List pgsql-hackers
On tor, 2011-01-20 at 03:16 +0100, Jan Urbański wrote:
> Here's an updated patch series for PL/Python refactoring. It was 16
> patches at first, 8 are committed, 1 got dropped, so we're down to 7.

> Refactor PLy_spi_prepare to save two levels of indentation.
> 
> Instead of checking if the arglist is NULL and then if its length is
> 0, do it in one step, and outside of the try/catch block.

Why is it a good idea to do the PLy_malloc calls outside of the
try/catch block?  Also, why call them when nargs is 0?




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Move test_fsync to /contrib.
Next
From: Dimitri Fontaine
Date:
Subject: Re: FOR KEY LOCK foreign keys