Re: psql: Add \dL to show languages - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: psql: Add \dL to show languages
Date
Msg-id 1295375744.29248.32.camel@jansson
Whole thread Raw
In response to Re: psql: Add \dL to show languages  (Josh Kupershmidt <schmiddy@gmail.com>)
Responses Re: psql: Add \dL to show languages  (Josh Kupershmidt <schmiddy@gmail.com>)
List pgsql-hackers
Hi Josh,

Nope, I do not have any better ideas than "DO Blocks?".

Everything looks good with the exception one bug now.

\dL foo
********* QUERY **********
SELECT l.lanname AS "Name",      pg_catalog.pg_get_userbyid(l.lanowner) as "Owner",      l.lanpltrusted AS "Trusted"
FROM pg_catalog.pg_language lWHERE l.lanname ~ '^(foo)$'

ORDER BY 1;
**************************

ERROR:  syntax error at or near "l"
LINE 4: FROM pg_catalog.pg_language lWHERE l.lanname ~ '^(foo)$'


I believe the fix is to move \n from before the WHERE clause to after
the FROM, and from before ORDER BY to after WHERE.

Fix this bug and I believe this patch is ready for a committer.

PS. You added some trailing withspace after printACLColumn, A
recommendation if you want to avoid it is to either have a git commit
hook which checks for that and/or have colouring of git diffs so you can
see it marked in red. I use both. :)

Andreas




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: limiting hint bit I/O
Next
From: Simon Riggs
Date:
Subject: Re: pg_basebackup for streaming base backups