Re: pg_basebackup for streaming base backups - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_basebackup for streaming base backups
Date
Msg-id 1295357056-sup-9992@alvh.no-ip.org
Whole thread Raw
In response to Re: pg_basebackup for streaming base backups  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pg_basebackup for streaming base backups  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Excerpts from Magnus Hagander's message of mar ene 18 08:40:50 -0300 2011:
> On Tue, Jan 18, 2011 at 10:49, Fujii Masao <masao.fujii@gmail.com> wrote:

> > +                                       fprintf(stderr, _("%s: could not write to file '%s': %m\n"),
> >
> > %m in fprintf is portable?
> 
> Hmm. I just assumed it was because we use it elsewhere, but I now see
> we only really use it for ereport() stuff. Bottom line is, I don't
> know - perhaps it needs to be changed to use strerror()?

Some libc's (such as glibc) know about %m, others presumably don't (it's
a GNU extension, according to my manpage).  ereport does the expansion
by itself, see expand_fmt_string().  Probably just using strerror() is
the easiest.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: REVIEW: Extensions support for pg_dump
Next
From: Alvaro Herrera
Date:
Subject: Re: ToDo List Item - System Table Index Clustering