Re: Tab completion for ALTER ... SET SCHEMA - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: Tab completion for ALTER ... SET SCHEMA
Date
Msg-id 1292639411.27475.14.camel@jansson
Whole thread Raw
In response to Re: Tab completion for ALTER ... SET SCHEMA  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Tab completion for ALTER ... SET SCHEMA  (Robert Haas <robertmhaas@gmail.com>)
Re: Tab completion for ALTER ... SET SCHEMA  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
On Fri, 2010-12-17 at 21:20 -0500, Robert Haas wrote:
> On Fri, Dec 17, 2010 at 9:14 PM, Andreas Karlsson <andreas@proxel.se> wrote:
> > What it does is gets rid of the incorrect completion which comes from
> > the completion rule for "SET foo TO bar" by adding the correct
> > completion for "SET SCHEMA" higher up in the completion function.
> >
> > So instead of an incorrect completion we get the correct one.
> 
> But that's not necessarily wrong, if "foo" happens to be the name of a GUC.

Agreed, which is why I made the new rule only match

ALTER x x SET SCHEMA

while the rest will fall down and match

SET

.  So I should be safe since SCHEMA is a reserved words. When I think of
it I may even have be unnecessary to require the ALTER verb.

Regards,
Andreas




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Tab completion for ALTER ... SET SCHEMA
Next
From: Robert Haas
Date:
Subject: Re: Tab completion for ALTER ... SET SCHEMA