Re: pgsql: Assorted cleanups in preparation for using a map file to support - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Assorted cleanups in preparation for using a map file to support
Date
Msg-id 1265191529.1729.2239.camel@ebony
Whole thread Raw
In response to pgsql: Assorted cleanups in preparation for using a map file to support  (tgl@postgresql.org (Tom Lane))
List pgsql-committers
On Wed, 2010-02-03 at 01:14 +0000, Tom Lane wrote:

> 1. Get rid of inval.c's dependency on relfilenode, by not having it emit
> smgr invalidations as a result of relcache flushes.  Instead, smgr sinval
> messages are sent directly from smgr.c when an actual relation delete or
> truncate is done.  This makes considerably more structural sense and allows
> elimination of a large number of useless smgr inval messages that were
> formerly sent even in cases where nothing was changing at the
> physical-relation level.  Note that this reintroduces the concept of
> nontransactional inval messages, but that's okay --- because the messages
> are sent by smgr.c, they will be sent in Hot Standby slaves, just from a
> lower logical level than before.

Presumably this means that SHAREDINVALSMGR_ID messages are no longer
part of the invalidation messages attached to a commit record?

If so, there is some minor code cleanup and comment changes in
ProcessCommittedInvalidationMessages(). Would you like me to do that, or
should we wait?

--
 Simon Riggs           www.2ndQuadrant.com


pgsql-committers by date:

Previous
From: heikki@postgresql.org (Heikki Linnakangas)
Date:
Subject: pgsql: Move the responsibility of writing a "unlogged WAL operation"
Next
From: meskes@postgresql.org (Michael Meskes)
Date:
Subject: pgsql: Fixed some typos in ECPG regression test suite that resulted in