Re: operator exclusion constraints - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: operator exclusion constraints
Date
Msg-id 1259731114.3355.126.camel@jdavis
Whole thread Raw
In response to Re: operator exclusion constraints  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: operator exclusion constraints
Re: operator exclusion constraints
Re: operator exclusion constraints
Re: operator exclusion constraints
List pgsql-hackers
On Tue, 2009-12-01 at 23:19 -0500, Robert Haas wrote:
> For parity with unique constraints, I think that the message:
>
> operator exclusion constraint violation detected: %s
>
> should be changed to:
>
> conflicting key value violates operator exclusion constraint "%s"

Done, and updated tests.

> In ATAddOperatorExclusionConstraint, "streatagy" is misspelled.

Fixed.

> Other than that, it looks good to me.

Great, thanks for the detailed review!

Regards,
    Jeff Davis

Attachment

pgsql-hackers by date:

Previous
From: KaiGai Kohei
Date:
Subject: Re: SE-PgSQL patch review
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] bugfix for int2vectorin