Re: unknown libpq service entries ignored - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: unknown libpq service entries ignored
Date
Msg-id 1259360169.4396.27.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: unknown libpq service entries ignored  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On fre, 2009-11-27 at 10:22 -0500, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > +        printfPQExpBuffer(errorMessage,
> > +                          libpq_gettext("ERROR: service \"%s\" not found\n"), service);
> 
> Please make the message consistent with the rest of libpq.  AFAICS none
> of the other messages in that file use an ERROR: prefix.

Well, that style is used four times in that same function, but no where
else in the file.  So the existing uses should probably also be cleaned
up.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: OpenSSL key renegotiation with patched openssl
Next
From: Tom Lane
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Rewrite GEQO's gimme_tree function so that it always finds a