Re: convert libpq uri-regress tests to tap test - Mailing list pgsql-hackers

From Tom Lane
Subject Re: convert libpq uri-regress tests to tap test
Date
Msg-id 1257142.1645653836@sss.pgh.pa.us
Whole thread Raw
In response to convert libpq uri-regress tests to tap test  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2022-Feb-23, Andres Freund wrote:
>> Separately: I don't really understand why we do the whole if USE_PGXS dance in
>> src/test/modules?

> Yeah, it seems a bit silly.  I'm not opposed to making these makefiles
> unconditionally do the PGXS thing -- or the non-PGXS thing, if that
> makes it easier to build multiple binaries.

Agreed, we could easily lose that.  I think we only do it in contrib
to serve as an example of how to use PGXS ... although considering
we're not *testing* that build mode, one wonders how much that proves.
In any case, src/test/modules doesn't have to do it.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: convert libpq uri-regress tests to tap test
Next
From: Tom Lane
Date:
Subject: Re: reallocing without oom check in pg_regress