Re: problem with plural-forms - Mailing list pgsql-hackers

From Zdenek Kotala
Subject Re: problem with plural-forms
Date
Msg-id 1243342907.1296.9.camel@localhost
Whole thread Raw
In response to Re: problem with plural-forms  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut píše v út 26. 05. 2009 v 13:39 +0300:
> On Monday 25 May 2009 19:11:24 Zdenek Kotala wrote:
<snip>
> >
> > The problem here is (1 row) instead of (%lu row). When I run msgfmt
> > without -v everything works fine but I think we should fixed it (there
> > are more occurrences of this issue).
> 
> GNU gettext accepts this, and in fact the GNU gettext documentation explicitly 
> points out that this allowed:
> 
> """
>      In the English singular case, the number - always 1 - can be
>      replaced with "one":
> 
>           printf (ngettext ("One file removed", "%d files removed", n), n);
> 
>      This works because the `printf' function discards excess arguments
>      that are not consumed by the format string.
> """

Yeah, I check also printf specification and it is allowed.

> One might consider this better style (English style, not C style) in some 
> contexts.
>
> Of course the concrete example that you show doesn't actually take advantage 
> of this, so if it is important to you, please send a patch to fix it.

It is not a big issue, because it works without -v but I prefer to fix
it. I will send a patch. I also sended question to i18n solaris group if
it is supported on solaris.
thanks Zdenek





pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [PATCH] cleanup hashindex for pg_migrator hashindex compat mode (for 8.4)
Next
From: Robert Haas
Date:
Subject: Re: generic options for explain