citex regression fails with de.UTF8 locale - Mailing list pgsql-hackers

From Zdenek Kotala
Subject citex regression fails with de.UTF8 locale
Date
Msg-id 1240468074.1275.7.camel@localhost
Whole thread Raw
Responses Re: citex regression fails with de.UTF8 locale  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
I setup more locale testing on gothic moth and citext regression test
fails.

See
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-04-22%2020:06:01


Problem is here:

---------------------------------------------------
SELECT citext_cmp('B'::citext, 'a'::citext) AS one;  one  -----
!    1 (1 row)  -- Do some tests using a table and index.
--- 216,222 ---- SELECT citext_cmp('B'::citext, 'a'::citext) AS one;  one  -----
!   28 (1 row)  -- Do some tests using a table and index.
---------------------------------------------------

It seems to me that citex_cmp can return any integer value. It depends
what wcscoll() returns. I think it should be changed to:

SELECT citext_cmp('B'::citext, 'a'::citext) > 0 AS one;
Zdenek






pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: The last WAL segment of the old timeline is not archived for a while after archive recovery
Next
From: Heikki Linnakangas
Date:
Subject: Re: citex regression fails with de.UTF8 locale